fix: [MR-179] added container-side event emitter for AppEventPayload - #290
Open
janfb-codev wants to merge 1 commit into
Open
fix: [MR-179] added container-side event emitter for AppEventPayload#290janfb-codev wants to merge 1 commit into
janfb-codev wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AppEventEmitteras the single entry point for emitting anAppEventPayload. Java callers can now emit events without going through the WebView bridge, which was previously the only way in.AppEventPayloadBuilderfor Java-side payload construction..add()/.replace()populatedataandoptionstogether so an invalid merge option is unconstructible, andtimestampis stamped automatically.AppEventWriteCallback(onQueued/onWritten/onFailed).onQueuedfires when the write is durable in Firestore's local persistence queue;onWrittenfires only on server ack, which offline may be much later or never. Callers holding the only other copy of a measurement should release it ononQueued.WebApp.logMessage()now delegates to the emitter JSON parsing, validation and dispatch moved out of the Activity.WebApptoAppEventEmitter(message text unchanged).Groundwork for MR-180 through MR-184, which write container-measured sub-app usage into
summary_data.How to test
summary_dataanduser_sessions_dataare written exactly as before samemetadata(includingcontainer_app_version,country,language), sameattribution, anddatafields still accumulating rather than overwriting.adb logcat -s AppEventEmitter AppEventHandler.Ref: MR-179