Repository navigation
1.7: package descriptor schema draft + 3 validated descriptors (phase 1 unit 1.7) - #42
Open
cunninghamcard-bit wants to merge 1 commit into
Open
cunninghamcard-bit wants to merge 1 commit into
cunninghamcard-bit wants to merge 1 commit into
Conversation
…ible descriptors descriptors/package-descriptor.schema.json (JSON Schema 2020-12) requires every arcships#200 §6.5 descriptor field and stays credential-free data per RFC-0040 §2.1. Three descriptors written from the Rust factories validate; the schema rejects 8 malformed edits; provider-string examples match the factories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 unit 1.7: descriptor schema draft. It follows arcships#200 §6.5 (
docs/aisdk-architecture-alignment.md:1324) and RFC-0040 §2.1 (rfc/0040-provider-auth.md, from commit 3757cfd; that file is not in exp/restart). The branch is cut fromexp/restart@ 8455db9, and the PR base isexp/restart.Added
descriptors/package-descriptor.schema.json(JSON Schema 2020-12).package_id,factory,settings_schema,credential_fields,runtime_handle_fields,methods(holding the method list anddefault_method),name_semantics,provider_string_rules,provider_options_rules,tools,extensions(holdingdiscovery),auth(holdingoffline_auth_recipe),catalogue_mapping,audit_metadata,supported_featuresandsource_verification.additionalProperties: falseis set throughout.{"env": ...}.descriptors/{openai,anthropic,openai-compatible}.json, written from the Rust factories and settings:openai/mod.rs:187,:239,:309-385anthropic/mod.rs:110,:164,:255-295openai_compatible/mod.rs:60,:120,:208-245Each pins its SDK version from
fixtures/aisdk/VERSIONS.json(openai 4.0.83, anthropic 4.0.71, openai-compatible 3.0.62). Tool ids are the ones found in the source.aimux-providers/tests/descriptor_schema_test.rs, plus ajsonschemadev-dependency (a workspace dependency already present for aimux-core). It has four tests:every_descriptor_validates: all 3 descriptors pass the schema. This is the PHASES acceptance check.schema_rejects_malformed_descriptors: the schema rejects each of 8 edits, so it is not vacuous:body_overrides)descriptors_are_internally_consistent: checks rules the schema can't express:provider_string_examples_match_the_factories: each descriptor's provider-string examples equal whatcreate_openai,create_anthropicandcreate_openai_compatibleactually report. The callable provider's default method matchesdefault_method.The descriptors are not wired into anything yet. Generation and the manifest come later (1.8 and phase 3). Fixture and cassette diff: zero.
Results (local linux x64)
Python was not run (no venv). The schema field names and shapes are a draft for review. arcships#200 §6.5 names the fields but not their structure. "arcships#214 factories" and "arcships#219 types" in PHASES refer to upstream PRs; the samples here were written from the current code that came out of them.