Repository navigation
E.6: A7 enum-family audit, conclusion and file:line per row (docs; E.5 needs no changes) (on #31) - #37
Open
cunninghamcard-bit wants to merge 1 commit into
Conversation
….5 has no remaining changes)
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit E.6 (PHASES 1E). Docs only. Stacked on #31 (E.4,
a498558a), and the PR base isexp/e4-tool-input-start-kind.E.5 has no remaining changes, so it has no PR
The E.5 acceptance check is
rg -n '\.dynamic\b|\.invalid\b' aimux-* tools. At the E.4 head it finds only:tool.rs:369-370,:686,:690.RawToolCallfields (provider-layer three-state data):parse_tool_call.rs:107,:192tool_input_test.rs:30,:212mistral_upstream_e2e_test.rs:203ToolResult::dynamic():provider_executed_marking_test.rs:88,data_loss_regression_test.rs:275.test.invalidURLs.No source code reads wire fields such as
["dynamic"],["invalid"],["providerExecuted"]orget(...), either. Every consumer listed in PHASES E.5 already uses accessors ormatch:GenerateContent/TextContent,ToolApprovalRequestOutput.tool_call,aimux-stream,aimux-ffi, providers and tools. The compiler forced that when E.2–E.4 changed the types. The two internal functions in A7 (parsed_tool_call_arguments,response_tool_call_input) already take&ToolCall.E.6
I appended a conclusion table to
docs/amendments/A7-enum-state-modeling.md. Every A7 row now has a conclusion and a file:line:MessageContent/ModelPrompt(message.rs:28,:82) useuntagged.aimux-provider/src/content.rs:84,:99.The table also records the E.4 decision: D25's "always write" rule applies only to core
TextStreamPart, and the provider-layerStreamPartpasses the value through.No code changed, so no tests were re-run. The numbers from #31 still apply.