Repository navigation
A.3: is_retryable assertions on OpenAI chat errors (phase 1A; on #20) - #30
Open
cunninghamcard-bit wants to merge 1 commit into
Open
cunninghamcard-bit wants to merge 1 commit into
cunninghamcard-bit wants to merge 1 commit into
Conversation
AI SDK api-call-error.ts:28-32.
11 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1A unit A.3 (A9; PHASES 1A). Stacked on #20 (
exp/u1R.2-remove-retry-config@ 94ed020), and the PR base is that branch.aimux-providers/tests/openai_upstream_e2e_test.rs:chat_error_response(the 429 case) now also assertserror.is_retryable, right after the status/data assertions (post-R.2 line 196).chat_error_response_400_is_not_retryable: a 400invalid_request_errorgivesApiCallwithstatus_code == Some(400), and the test asserts!error.is_retryable.api-call-error.ts:28-32.The bindings were not re-run, since this change only touches tests.