security: wave 2 fixes (branch protection + code bugs + hygiene)#4
Merged
govindkavaturi-art merged 2 commits intomainfrom Apr 12, 2026
Merged
security: wave 2 fixes (branch protection + code bugs + hygiene)#4govindkavaturi-art merged 2 commits intomainfrom
govindkavaturi-art merged 2 commits intomainfrom
Conversation
- Enable require_last_push_approval on main branch protection - Add .env* to .gitignore - Add "Handling Failures Safely" section to README - Add onFailure redaction hook to v0.2 roadmap - Validate retry.maxAttempts (1-20 range, integer) in defineStep - Fix runGates to attribute thrown gate exceptions as type "gate" - Add CODEOWNERS for critical paths - Add tests for maxAttempts validation and throwing gates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_last_push_approvalonmainbranch protection.env*to.gitignoreto prevent accidental secret commitsonFailurehook for v0.2retry.maxAttemptsindefineStep()— must be integer between 1 and 20runGates()to attribute thrown exceptions astype: "gate"not"exception".github/CODEOWNERSrequiring review from @govindkavaturi-art for critical pathsAddresses findings #6, #8, #11, #12, #13, #14 from the security audit.
Test plan
maxAttemptsvalidation (4 tests) + throwing gate attribution (1 test)gh api repos/cueapi/cuechain/branches/main/protection🤖 Generated with Claude Code