Remove monitor for now + add CI to Runt tests - #287
Merged
Conversation
…nic error messages
ngernest
changed the title
This was referenced Jul 18, 2026
ngernest
marked this pull request as ready for review
July 18, 2026 20:06
* Add new FailureKind enum to BI * Error-handling for BI when fork is called before step * Update expect files for tests that previously panicked due to the 'fork before step' failure * Add --max-traces argument to the nested_busy_wait test case to avoid too many traces from showing up * Add --max-traces to push_pop_loop_empty test, update Runt expected output * Propagate --color CLI flag to diagnostic handler * Update Runt expect files (error messages no longer contain color) * Fix remaining failing test case involving a panic due to unsupported time unit * formatting * Add one extra comment * Remove malformed protocols (repeat loops with 0 iterations causing fork before step) + their associated tests * Remove FailureKind enum, address Kevin's comments re: where error message formatting should happen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CI currently fails on this branch as the BI
panics on certain test cases -- this is addressed in #289, so #289 should be reviewed before this PR (#289 is to be merged into this branch, which will allow CI to pass).This PR removes the monitor (per Slack discussion) and updates
MONITOR_CASESin the Runt test infrastructure toBI_CASES, withmonitor.expectfiles renamed tobi.expectand updated to contain the output of the BI.