fix: make RestService tests config-aware#1380
Merged
MariusWirtz merged 3 commits intomasterfrom Apr 8, 2026
Merged
Conversation
The wait_time_generator and parameter assertion tests were hardcoding expected values (0.1s initial delay, 1.0s max, etc.) that break when config.ini overrides those defaults. Now the generator tests explicitly set and restore polling attributes, and the default-parameter tests read expected values from config.ini. Fixes #1368, #1369, #1370, #1371, #1372, #1373, #1374, #1375, #1376, #1377, #1378, #1379 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicolasbisurgi
added
the
release:patch
The second test_delete_edges_use_ti_skip_invalid_edges_true (with use_ti=True) was shadowing the first one (default path). Renamed to test_delete_edges_use_ti_and_skip_invalid_edges_true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicolasbisurgi
added
automation
and removed
release:patch
MariusWirtz
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_default_remote_disconnect_parameters,test_default_async_polling_parameters) now read expected values fromconfig.iniwith fallback to code defaults, instead of hardcoding valuesinitial_delay,max_delay,backoff_factor) to fixed values in each test, isolating generator logic from config overridesconfig.inipolling/retry settingsRoot cause
After adding
async_polling_*andremote_disconnect_*overrides to the CIconfig.inito mitigate RemoteDisconnect failures, the RestService tests broke because they asserted hardcoded default values that no longer matched the configured ones.Fixes #1368, #1369, #1370, #1371, #1372, #1373, #1374, #1375, #1376, #1377, #1378, #1379
Test plan
🤖 Generated with Claude Code