Fix use_keyring support in build command and TM1 integration#131
Merged
nicolasbisurgi merged 2 commits intomasterfrom Mar 27, 2026
Merged
Fix use_keyring support in build command and TM1 integration#131nicolasbisurgi merged 2 commits intomasterfrom
nicolasbisurgi merged 2 commits intomasterfrom
Conversation
Resolves #129. The use_keyring config option was only handled in the main execution path but missing from rushti build and connect_to_tm1_instance. Extract shared resolve_tm1_params() helper to centralize keyring resolution and non-TM1Service param cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The top-level `import keyring` in tm1_integration.py fails in CI where no keyring backend is installed. Move to a lazy import inside resolve_tm1_params (only when use_keyring is actually enabled). Also set up getboolean/get mocks in test_connect_success so the mock ConfigParser works with resolve_tm1_params. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicolasbisurgi
added
the
release:patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_keyringconfig option was only handled in the main execution path but missing fromrushti buildandconnect_to_tm1_instanceresolve_tm1_params()helper intm1_integration.pythat centralizes keyring password resolution and non-TM1Service param cleanup (use_keyring,session_context,connection_file)Test plan
rushti buildwithuse_keyring=truein config.ini and verify cube/dimension creation succeeds--tm1-instancewithuse_keyring=true) and verify task execution succeedsuse_keyring=trueand verify it still workspassworddirectly in config (no keyring) and verify no regressionpython -m pytest tests/unit/ -x -q🤖 Generated with Claude Code