Conversation
…saction report) and bring reporting up to new UI spec
Resell you mean? :-) |
thisjustin123
left a comment
There was a problem hiding this comment.
Everything looks pretty good to me! Do you have a demo of the new reporting stuff? Or can you not navigate to it yet?
thisjustin123
left a comment
There was a problem hiding this comment.
Plz add a demo of the old reporting (front-end) flow working, since all of that was hooked up fine.
It's good to test this still since your old code might have unknowingly broken them, lol.
zachseidner1
left a comment
There was a problem hiding this comment.
Changes look good on paper, but a bit confused as to why you opened a PR for this. In Next Steps you said that reporting is broken and you want to revisit this. So maybe this should just be a draft PR? Also as Justin requested, could you include a demo video of the changes? I think the PR we're looking for now then is the PTF.
Overview
Adds a new report type to Resell and modifies the existing reporting UI.
Changes Made
Demo Video:
resell.test.reporting.mp4
Next Steps
Connect to PTF