[Home/Search Screen UI] - Implement Home/Search Screen UI by AndrewCheung360 · Pull Request #9 · cuappdev/hustle-android

AndrewCheung360 · 2025-11-19T04:23:44Z

Overview

Implement the ui for the Home/Search screen
https://www.figma.com/design/tRFDgfOFDXGXREx6q33p4P/Hustle?node-id=577-3679&t=ekSdFryK6xeB87PV-0

Changes Made

Created Category Button Row for main view of home screen
Created MainContent composable for the main view of home screen (as opposed to search view)
Created SearchContent composable for the search view of home screen
Created Search Header composable with animation for switching between main and search view
Created routes for CategoryServices along with enum class with companion object function for determining the enum based on associated string type name
Created CategoryServices entry in homenavigation navgraph and passed in some nav functions to home screen
Put together composables to implement home screen ui with test variables
Updated testing constants with more variety

Test Coverage

Emulator and Preview testing

Next Steps

Add networking with vm usage once backend is ready
Implement the search result screens and add proper navigation logic

Related PRs

[Home/Search Screen UI] - Foundation: General Components, Icon Assets, Bottom Navigation Update, Constants #8

Screenshots

Details

Screen.Recording.2025-11-16.at.1.21.47.AM.mov

…stants

Copilot

Pull Request Overview

This PR implements the Home/Search Screen UI for the Hustle Android app, introducing a two-mode interface with smooth animations between main browsing and search states.

Key Changes:

Created a dual-mode home screen with animated transitions between main content and search views
Implemented category-based navigation with button row and clickable section headers
Added search functionality with recent searches and recently viewed services

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
TestingConstants.kt	Enhanced test data with diverse service examples across multiple categories
HomeScreen.kt	Main screen composable with state management and animated content switching
HomeNavigation.kt	Added navigation handlers for service details and category subpages
Routes.kt	Introduced CategoryType enum with serialization support and typeName mapping
HustleNavigation.kt	Removed unused currentRoute variable
SearchHeader.kt	Animated header with search bar that slides up when search is active
SearchContent.kt	Search view with recent searches and recently viewed services sections
MainContent.kt	Main view with category buttons and multiple service carousels
CategoryButtonRow.kt	Horizontal scrollable row of category filter buttons

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-19T04:26:41Z

app/src/main/java/com/cornellappdev/hustle/util/constants/TestingConstants.kt

        ),
-        displayImageUrl = "https://news.cornell.edu/sites/default/files/styles/full_size/public/06_2023_1114_sh_005-n_1.jpg?itok=E3ecxgYl",
-        priceUnit = "/hour",
+        displayImageUrl = "https://s3-media0.fl.yelpcdn.com/bphoto/1KwtwltxdEYVz4TIHAzaow/1000s.jpg"


Missing priceUnit field for Service id=3. While the Service model has a default value of \"\", this service should have priceUnit = \"/hour\" for consistency with the other test services.

Suggested change

displayImageUrl = "https://s3-media0.fl.yelpcdn.com/bphoto/1KwtwltxdEYVz4TIHAzaow/1000s.jpg"

displayImageUrl = "https://s3-media0.fl.yelpcdn.com/bphoto/1KwtwltxdEYVz4TIHAzaow/1000s.jpg",

priceUnit = "/hour",

some services might not be by hour

Copilot · 2025-11-19T04:26:42Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/Routes.kt

+    companion object {
+        fun fromTypeName(typeName: String): CategoryType {
+            return entries.firstOrNull { it.typeName == typeName }
+                ?: throw IllegalArgumentException("No CategoryType with typeName $typeName found.")


The error message could be more helpful by including the valid typeName options. Consider: \"Unknown CategoryType '$typeName'. Valid types: ${entries.map { it.typeName }}\"

Suggested change

?: throw IllegalArgumentException("No CategoryType with typeName $typeName found.")

?: throw IllegalArgumentException("Unknown CategoryType '$typeName'. Valid types: ${entries.map { it.typeName }}")

will end up removing this function

Copilot · 2025-11-19T04:26:42Z

app/src/main/java/com/cornellappdev/hustle/ui/components/home/MainContent.kt

+                            onClick = {
+                                navigateToCategorySubpage(CategoryType.POPULAR_RIGHT_NOW)
+                            },
+                            modifier = Modifier.padding(start = 32.dp)


Hardcoded padding value 32.dp should use HustleSpacing.large (which is 24.dp) or another appropriate spacing constant for consistency. This value appears on lines 58, 73, 88, and 103.

good thought, but would need to consult design

zachseidner1

Nice! I think we should get rid of the fromTypeName function but looks good otherwise

zachseidner1 · 2025-11-19T19:30:21Z

app/src/main/java/com/cornellappdev/hustle/ui/screens/home/HomeScreen.kt

+    popularRightNowListings: List<Service>,
+    newOnHustleListings: List<Service>,
+    servicesNearYouListings: List<Service>,
+    availableThisWeekListings: List<Service>,
+    recentSearches: List<String>,
+    recentlyViewedServices: List<Service>,


Nit: This is a lot of data to be passing in as separate parameters. To avoid parameter drilling, it could be nicer to make a data class HomeScreenViewState that contains the data the home screen needs to render

That makes sense, I'll add it to the HomeScreen file

zachseidner1 · 2025-11-19T19:31:23Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/Routes.kt

+    AVAILABLE_THIS_WEEK("Available this week");
+
+    companion object {
+        fun fromTypeName(typeName: String): CategoryType {


do you think we should just make this fromTypeNameOrNull and have the caller handle the failure case to avoid the potential for crashing the app?

I'm thinking of refactoring this such that the composable that will use this won't need to use this function, so I'll probably remove it.

zachseidner1 · 2025-11-19T19:33:43Z

app/src/main/java/com/cornellappdev/hustle/ui/screens/home/HomeScreen.kt

+            onSearch = onSearch,
+            modifier = Modifier.padding(horizontal = HustleSpacing.large)
+        )
+        AnimatedContent(


You found a way to state the two states of this screen very simply so we don't have to navigate to a new screen when this is pressed. This looks great, nice job!

zachseidner1 · 2025-11-19T19:35:35Z

app/src/main/java/com/cornellappdev/hustle/ui/components/home/MainContent.kt

+    val popularRightNowListings = TEST_SERVICES
+    val newOnHustleListings = TEST_SERVICES
+    val servicesNearYouListings = TEST_SERVICES
+    val availableThisWeekListings = TEST_SERVICES


nit: maybe we just pass in TEST_SERVICES directly?

lol, I kinda forgot about that.

zachseidner1 · 2025-11-19T19:49:13Z

app/src/main/java/com/cornellappdev/hustle/ui/components/home/SearchHeader.kt

+            enter = fadeIn() + scaleIn(),
+            exit = fadeOut(animationSpec = tween(150)) + shrinkHorizontally(
+                shrinkTowards = Alignment.Start,
+                animationSpec = tween(150)
+            )


Love this animation!

zachseidner1 · 2025-11-19T19:51:57Z

app/src/main/java/com/cornellappdev/hustle/ui/components/home/CategoryButtonRow.kt

+    ) {
+        items(SERVICE_CATEGORIES, key = { it.name }) { category ->
+            HustleButton(
+                onClick = { onCategoryClick(CategoryType.fromTypeName(category.name)) },


can't we just directly pass in category to onCategoryClick, removing the need for the fromTypeName function entirely?

I'm planning on moving the categorytype definition to HustleConstants and replacing the ServiceCategory type's name field with categoryType: CategoryType, so that should remove the need for the extra function

…nviewstate

AndrewCheung360 added 2 commits November 18, 2025 22:58

Implement home and search screen ui base

7ee227f

Updated nav route name, removed unused route, and updated testing con…

f56cbe8

…stants

AndrewCheung360 requested review from Mihilih, Copilot and zachseidner1 November 19, 2025 04:24

Copilot started reviewing on behalf of AndrewCheung360 November 19, 2025 04:24 View session

Copilot finished reviewing on behalf of AndrewCheung360 November 19, 2025 04:26

Copilot AI reviewed Nov 19, 2025

View reviewed changes

AndrewCheung360 self-assigned this Nov 19, 2025

AndrewCheung360 added the enhancement New feature or request label Nov 19, 2025

zachseidner1 reviewed Nov 19, 2025

View reviewed changes

Removed typename function, refactored categorytype, created homescree…

93559c5

…nviewstate

AndrewCheung360 requested a review from zachseidner1 November 19, 2025 21:13

AndrewCheung360 merged commit 971f99e into main Nov 20, 2025
3 checks passed

	displayImageUrl = "https://s3-media0.fl.yelpcdn.com/bphoto/1KwtwltxdEYVz4TIHAzaow/1000s.jpg"
	displayImageUrl = "https://s3-media0.fl.yelpcdn.com/bphoto/1KwtwltxdEYVz4TIHAzaow/1000s.jpg",
	priceUnit = "/hour",

	?: throw IllegalArgumentException("No CategoryType with typeName $typeName found.")
	?: throw IllegalArgumentException("Unknown CategoryType '$typeName'. Valid types: ${entries.map { it.typeName }}")

Conversation

AndrewCheung360 commented Nov 19, 2025

Overview

Changes Made

Test Coverage

Next Steps

Related PRs

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zachseidner1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewCheung360 Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AndrewCheung360 Nov 19, 2025 •

edited

Loading