Skip to content

Codex-generated pull request#4

Open
ctsunny wants to merge 1 commit intomainfrom
codex/locate-issue-preventing-button-clicks-xke93e
Open

Codex-generated pull request#4
ctsunny wants to merge 1 commit intomainfrom
codex/locate-issue-preventing-button-clicks-xke93e

Conversation

@ctsunny
Copy link
Owner

@ctsunny ctsunny commented Mar 17, 2026

Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.


Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a692b5a835

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

document.getElementById('reloadBtn').addEventListener('click', function() {
location.reload();
});
pollData();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore hard reload for manual refresh

Changing the manual refresh button to pollData() means it no longer reflects newly added or removed clients, because pollData only updates rows that already exist and skips unknown clients (if (!row) return). In practice, when a new client registers, clicking “手动刷新” will still not show it until the user does a full browser reload, which is a regression from the previous location.reload() behavior.

Useful? React with 👍 / 👎.

Comment on lines +1573 to +1575
q.Set("gen_cmd", cmd)
}
http.Redirect(w, r, panelPath+"?"+q.Encode(), http.StatusFound)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep generated install command out of URL query

The generated command contains --init-token and is now persisted into gen_cmd query params before redirecting back to the panel. This places the init token in the URL, which is typically captured by browser history and HTTP access logs (and can be propagated via referrer headers), increasing credential exposure compared with keeping the command only in page state.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant