Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a692b5a835
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| document.getElementById('reloadBtn').addEventListener('click', function() { | ||
| location.reload(); | ||
| }); | ||
| pollData(); |
There was a problem hiding this comment.
Restore hard reload for manual refresh
Changing the manual refresh button to pollData() means it no longer reflects newly added or removed clients, because pollData only updates rows that already exist and skips unknown clients (if (!row) return). In practice, when a new client registers, clicking “手动刷新” will still not show it until the user does a full browser reload, which is a regression from the previous location.reload() behavior.
Useful? React with 👍 / 👎.
| q.Set("gen_cmd", cmd) | ||
| } | ||
| http.Redirect(w, r, panelPath+"?"+q.Encode(), http.StatusFound) |
There was a problem hiding this comment.
Keep generated install command out of URL query
The generated command contains --init-token and is now persisted into gen_cmd query params before redirecting back to the panel. This places the init token in the URL, which is typically captured by browser history and HTTP access logs (and can be propagated via referrer headers), increasing credential exposure compared with keeping the command only in page state.
Useful? React with 👍 / 👎.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task