Skip to content

Added appropriate error for blank field name heading in record imports (D1099) #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawelwlod wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Added appropriate error for blank field name heading in record imports (D1099) #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0602126
Added appropriate error for blank field name heading in record imports
pwlodarski-ctrlo Dec 17, 2025
c777096
Fix formatting on $col_count in _build_fields sub
pawelwlod Dec 17, 2025
87ddf70
Updated logic statement with regex to consider all whitespace characters
pwlodarski-ctrlo Dec 17, 2025
f52ac8a
Switched unless to if statement
pwlodarski-ctrlo Feb 27, 2026
979bf60
Updated import test to check if empty name error works
pwlodarski-ctrlo Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/GADS/Import.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,10 @@ sub _build_fields
my @fields;
my $column_id = $self->layout->column_id;

my $col_count = 0;
foreach my $field (@$fields_in)
{
$col_count++;
if (
(
($self->update_unique && $self->update_unique == $column_id->id) ||
Expand Down Expand Up @@ -298,6 +300,8 @@ sub _build_fields
$search->{name} = $field if !$self->short_names;
$search->{name_short} = $field if $self->short_names;
my $f_rs = $self->schema->resultset('Layout')->search($search);
error __x"Empty field name in import headings (Column {column})", column => $col_count
if $field =~ /^\s*$/;
error __x"Layout has more than one field named {name}", name => $field
if $f_rs->count > 1;
error __x"Field '{name}' in import headings not found in table", name => $field
Expand Down
16 changes: 15 additions & 1 deletion t/014_import.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,13 @@ my @tests = (
count_on => 1,
count_off => 1,
},
{
data => "string1, ,integer1\nFoo,Bar,123",
option => undef,
error => qr\Empty field name\,
count_on => 1,
count_off => 1,
},
{
data => "string1\nString content",
option => 'dry_run',
Expand Down Expand Up @@ -228,7 +235,14 @@ foreach my $test (@tests)

my $test_name = defined $test->{option} ? "with option $test->{option} set to $status" : "with no options";
is($records->count, 0, "No records before import for test $test_name");
$import->process;

try { $import->process; };
if ($test->{error})
{
like($@, $test->{error}, "Got expected import error");
next;
}

$records->clear;
is($records->count, $test->{"count_$status"}, "Correct record count on import for test $test_name");

Expand Down
Loading