fix: stop native audio sources during playback cleanup - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sound.cleanup()disconnected buffer sources without stopping them, so native loops kept running and retaining decoded audio. Stop started sources during terminalPlayback.cleanup(), after detaching the end callback. Preserve shared Sound buffers, sibling voices, and stopped-playback replay.Unit and native browser regressions failed before the fix and passed afterward. The browser fixture renders offline and reconnects the silent source after cleanup, proving that termination survives reconnection without depending on an audio device. The final fixture also failed against unchanged master and passed against the fix on Linux WebKit.
A controlled Chromium probe with 40 six-second stereo buffers retained 40 native sources and 92.16 MB of PCM before the fix; after the fix, no sources survived cleanup and that storage was released without closing the context.
Validation:
npm run buildnpx vitest runnpx biome ci .npx playwright test browser-tests/cleanup.spec.ts --project chromiumnpx playwright test browser-tests/cleanup.spec.ts --project firefox --project webkit(Firefox passed; Windows WebKit lacks AudioContext and skipped)