fix: emit seek events after accepted playback seeks - #237
Merged
Merged
Conversation
ctoth
force-pushed
the
fix/issue-213-seek-event
branch
from
September 13, 2026 17:13
b4c05d7 to
22a08e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit
seek(time)once after an accepted buffer or media-element playback seek. Cover successful and rejected seeks, and document why Sound does not relay a collective seek event.Closes #213
Validation:
npx vitest run src/playback.test.ts src/media-streaming-contract.test.ts(red, then green)npm run buildnpx vitest runnpx biome ci .git diff --check