Pytorch support - #276
Draft
cpozogonzalez wants to merge 121 commits into
Draft
Conversation
…ytorch legacy code
tjarkmiener
reviewed
Jul 27, 2026
Comment on lines
+19
to
+23
| tensorflow-version: ['latest', '2.16.*', 'none'] | ||
| torch-version: ['latest', '2.2.*', 'none'] | ||
| exclude: | ||
| - tensorflow-version: 'none' | ||
| torch-version: 'none' |
Member
There was a problem hiding this comment.
why you need none here? We always install both tensorflow/keras and torch flavors.
tjarkmiener
reviewed
Jul 27, 2026
Member
There was a problem hiding this comment.
Why we are loading the iris dataset and plot it in the pytest?
…nd move all the warnings to the debug options
tjarkmiener
reviewed
Jul 28, 2026
Comment on lines
+127
to
+134
| in_channels = input_shape[0] | ||
| in_channels = input_shape[-1] |
Member
There was a problem hiding this comment.
I don't understand why this is changed? pytorch input shape is channel first, i.e. (channel, height, width), right? Your data loader should supply the input data in this shape rather than changing the model
Collaborator
Author
There was a problem hiding this comment.
I alredy fix it was a mistake
tjarkmiener
requested changes
Jul 28, 2026
…, with 2 channels or 1 depend of the input (peak time or not)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.