Dependency Injection for game settings - #3
Open
simon123h wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings are currently implemented as a global data structure. In consequence, many methods rely on the global structure being present, i.e., they are poorly modularized.
This PR uses dependency injection (DI) to inject a Settings object into every method that wants to use any property from the settings. This increases testability of the methods by implementing a loose coupling between the settings data structure and the consuming methods.
This PR will also ultimately solve the issue where a powerup can change settings permanently if the game is cancelled before the timeout of the powerup can reset the game setting. Steps to reproduce: Let a tank pickup the MultiplierBonus powerup which increases the rate of powerups occurring. Hit the "Next Map" button. The rate of powerups occurring is permanently increased.
This issue will be solved when every instance of
Gamehas their own settings object, copied at Game creation time.