Skip to content

Fix IRF interpolation on macos#307

Open
maxnoe wants to merge 6 commits into
mainfrom
fix_interpolation_macos_arm
Open

Fix IRF interpolation on macos#307
maxnoe wants to merge 6 commits into
mainfrom
fix_interpolation_macos_arm

Conversation

@maxnoe
Copy link
Copy Markdown
Member

@maxnoe maxnoe commented Aug 14, 2025

Fixes #306

@maxnoe maxnoe requested a review from HealthyPear as a code owner August 14, 2025 10:17
@maxnoe maxnoe force-pushed the fix_interpolation_macos_arm branch from c5fa3fe to 84a7146 Compare August 14, 2025 10:18
@maxnoe maxnoe requested a review from RuneDominik as a code owner August 14, 2025 10:23
@maxnoe maxnoe requested a review from kosack September 18, 2025 11:01
Copy link
Copy Markdown
Member

@RuneDominik RuneDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original use of long double in the type check was, as far as I rember, only done to assert that even the use of a long double as input does not break the function. Thus, the check against float_max should preserve the orginal intent.

@moralejo
Copy link
Copy Markdown
Contributor

Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion of replacing np.float128 with np.float64 in pyirf to support IRF interpolation on macOS

3 participants