Skip to content

add validation function for psf norm#142

Open
AMWMitchell wants to merge 1 commit into
mainfrom
validate_irfs
Open

add validation function for psf norm#142
AMWMitchell wants to merge 1 commit into
mainfrom
validate_irfs

Conversation

@AMWMitchell
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2021

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.57%. Comparing base (aa63141) to head (b61c2fb).
⚠️ Report is 574 commits behind head on main.

Files with missing lines Patch % Lines
pyirf/validation.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   87.35%   86.57%   -0.79%     
==========================================
  Files          38       39       +1     
  Lines        1329     1341      +12     
==========================================
  Hits         1161     1161              
- Misses        168      180      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@HealthyPear HealthyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think the code is OK, but before approving I would like this PR to have 2 small additional things,

  • a unit-test under pyirf/tests/test_validation.py in which a PSF table not completely normalized is fed to the validate_psf which asserts the failure
  • a section in the docs at the same level of e.g. docs/utils.rst called docs/irf_validation.rst or docs/output_validation.rst in which this contribution is explained - then we can use that docs page to describe any other DL3 validation tool we might introduce (you can copy/paste/edit any docs section at the same level to get the same layout)

@HealthyPear HealthyPear added data validation enhancement New feature or request input/output Format and file extensions of the input/output data. labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data validation enhancement New feature or request input/output Format and file extensions of the input/output data.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants