add validation function for psf norm#142
Open
AMWMitchell wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 87.35% 86.57% -0.79%
==========================================
Files 38 39 +1
Lines 1329 1341 +12
==========================================
Hits 1161 1161
- Misses 168 180 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HealthyPear
requested changes
Mar 24, 2021
Member
There was a problem hiding this comment.
Thanks for this!
I think the code is OK, but before approving I would like this PR to have 2 small additional things,
- a unit-test under
pyirf/tests/test_validation.pyin which a PSF table not completely normalized is fed to thevalidate_psfwhich asserts the failure - a section in the docs at the same level of e.g.
docs/utils.rstcalleddocs/irf_validation.rstordocs/output_validation.rstin which this contribution is explained - then we can use that docs page to describe any other DL3 validation tool we might introduce (you can copy/paste/edit any docs section at the same level to get the same layout)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.