Modified Rake Object - #42
Open
calixo888 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of getters inside of the Rake object that don't need to be there. They only exist to return the already-accessible fields of the Rake object. I got rid of all of the getter methods and changed the names of some of the Rake fields. I also modified the input parameters of the Rake object to take in the target text to analyze, and added a setter method to change the text of the Rake object and update all corresponding fields.
Also, there are a lot of public fields that shouldn't be public, it gives the initialized a bad look. So I modified multiple fields to private, including metric, to_ignore, min_length, and max_length. I also figured some users may want to modify the stopwords or the punctuation to change the outcome metrics of the Rake object, so I created setters for both the stopwords and punctuation, and had the metrics of the Rake object be refreshed after the stopwords/punctuation changed.
I would greatly appreciate it if you made me a contributor, because I am very much interested in contributing more to this project, I think it's very interesting.