Replace concatenated strings with template strings - #1
Open
Shadow53 wants to merge 5 commits into
Open
Conversation
JavaScript has template strings, which allow embedded newlines and variable interpolation; this means that much less string trickery needs to happen to build the HTML. I've also used this to minimize the number of calls to `response.write()`.
I've been assigned 3005 as a port, so set that as default. Default hostname to "localhost" for development reasons. Add `./config.json` to gitignore.
New JSON file has a different structure. Technically the original code this assignment was based on could handle the JSON fine, but these changes add the keys as titles and makes each array a separate table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript has template strings, which allow embedded newlines and variable interpolation; this means that much less string trickery needs to happen to build the HTML. I've also used this to minimize the number
of calls to
response.write().