feat: analysis support for builtin modules#8
Open
werifu wants to merge 13 commits intocs-au-dk:masterfrom
Open
feat: analysis support for builtin modules#8werifu wants to merge 13 commits intocs-au-dk:masterfrom
werifu wants to merge 13 commits intocs-au-dk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @amoeller , I have done some work on supporting builtin modules of Node.js using an approach of mock as what you have taught me at last meeting.
I'm not sure if it's correct to mock the APIs by the method in my code, therefore I only wrote 4 modules related with module 'http' at the moment and I hope you could review it.
Please let me introduce what I have done in this PR:
resolveBultinModulewould do whattsResolveModuleNamedoes but only for builtin modules.I'm now still working for the rest APIs in builtin modules, but I need your advice before I continue this work in order to avoid meaningless work...
It also bothers me that how can I perform unit tests on all mocked APIs to guarantee the correctness.
I will appreciate it a lot If you could review my code and instruct me in this PR.