Repository navigation
T-1252 Cry Bot 云电脑:选 InstaBox 时面板文案仍写 Boat、未开机就报「快照操作失败」 - #69
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-polish # Conflicts: # src/components/ComputerPanel.tsx
Contributor
Author
|
操作者通过 --allow-credential-hit 放行以下凭据扫描命中(仅列位置):
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
| expect(provisioned.status).toBe(200); | ||
| const machineId = provisioned.body.machine.id; | ||
| const recorded = records(); | ||
| const fingerprint = createHash("sha256").update(env.INSTABOX_API_KEY).digest("hex").slice(0, 16); |
|
|
||
| export function createInstaboxMachines(request: InstaboxRequest): InstaboxMachines { | ||
| export function createInstaboxMachines(request: InstaboxRequest, records?: ReturnType<typeof createInstaboxMachineRecords>, apiKey?: string | null): InstaboxMachines { | ||
| const keyFingerprint = apiKey ? createHash("sha256").update(apiKey).digest("hex").slice(0, 16) : null; |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
台账任务
台账任务:T-1252
改了什么
T-1252
改了什么
server/routes/instabox-snapshots.e2e.test.tsserver/routes/instabox-snapshots.tsserver/instabox/snapshot-wiring.e2e.test.tsshared/place-view.tssrc/components/instabox-panel.test.tssrc/locales/en.jsonsrc/locales/source-hashes.jsonsrc/locales/zh.jsonverification.txt为什么
未建机时使用不含 Boat 的中性云桌面文案。快照列表先确认机器,不存在时返回空列表;真实上游失败仍返回错误并显示错误文案。补充组件和路由测试覆盖两处修复。
测试命令与结果摘要
pnpm exec vitest run shared/place-view.test.ts:19 passed。pnpm exec vitest run src/components/instabox-panel.test.ts:6 passed;src/components/InstaboxSnapshots.test.tsx:6 passed。pnpm exec vitest run server/routes/instabox-snapshots.e2e.test.ts:连续 3 次,每次 13 passed;server/instabox/snapshot-wiring.e2e.test.ts:连续 3 次,每次 6 passed。pnpm exec vitest run scripts/testing/file-size-ratchet.test.ts:1 passed。pnpm i18n:check、pnpm exec tsc -b --pretty false、pnpm exec tsc -p tsconfig.server.json、改动文件pnpm exec oxlint --deny-warnings、git diff --check:通过。server/verification-fixture.e2e.test.ts:1 passed、1 failed;失败是现有 fixture 将当前 Node 目录中的 CLI 误识别为可用,与本次改动无关。仓库中缺少 docs/verification/README.md,因此使用现有隔离 fixture;完整命令输出见
verification.txt。未提交 git。T-1252 第 3 轮
改了什么
electron/desktop-prefs.mjs、electron/desktop-prefs.node-test.mjs、server/routes/instabox-snapshots.e2e.test.ts、server/routes/instabox-snapshots.ts、server/testing/fake-instabox-snapshots.ts、shared/credential-request.ts、shared/place-view.test.ts、shared/place-view.ts、src/components/CloudBackendPicker.test.ts、src/components/CloudBackendPicker.tsx、src/components/ComputerPanel.simple.test.ts、src/components/ComputerPanel.tsx、src/components/InstaboxSnapshots.test.tsx、src/components/InstaboxSnapshots.tsx、src/components/bot-settings/AccessSection.tsx、src/components/keys/KeysPage.dom.test.ts、src/components/keys/key-catalog.test.ts、src/components/keys/key-catalog.ts、src/lib/remote-desktop.ts、src/locales/en.json、src/locales/no-retired-provider-visible.test.ts、src/locales/source-hashes.json、src/locales/zh.json、本报告、verification.txt。为什么
界面不再向用户暴露已下线的 Boat 入口或提示;快照操作在休眠状态先唤醒,并把真实并发冲突与上游拒绝分别反馈。
测试命令与结果摘要
pnpm exec vitest run相关前端/共享测试:8 files、146 passed;server/routes/instabox-snapshots.e2e.test.ts连续 3 次各 15 passed;server/instabox/snapshot-wiring.e2e.test.ts连续 3 次各 6 passed。pnpm exec vitest run scripts/testing/file-size-ratchet.test.ts:1 passed;node --test electron/desktop-prefs.node-test.mjs:23 passed。pnpm i18n:check、前端/服务端tsc、改动文件oxlint --deny-warnings、git diff --check:通过。zh/en 中仍含
Boat的位置只有boatOffer.*、keys.boat.*、place.action.addBoatKey等键名;对应值已改成 或云端桌面,键名为兼容旧配置而保留,没有用户可见的 Boat 字样。T-1252 第 4 轮
server/cloud-backend.test.ts、server/cloud-backend.ts、server/instabox/core.e2e.test.ts、server/instabox/snapshot-conflicts.e2e.test.ts、server/instabox/snapshot-wiring.ts、server/instabox/wiring.e2e.test.ts、server/new-bot-defaults.test.ts、server/new-bot-defaults.ts、server/routes/bot-patch.test.ts、server/routes/bots-create.test.ts、server/routes/instabox-snapshots.e2e.test.ts、server/routes/instabox-snapshots.ts、server/store.ts、server/testing/fake-instabox-core.ts、server/testing/fake-instabox-snapshots.ts、shared/place-view.test.ts、shared/place-view.ts、src/components/BotSettingsDialog.simple.test.ts、src/components/CloudBackendPicker.test.ts、src/components/CloudBackendPicker.tsx、src/components/ComputerPanel.android.test.ts、src/components/ComputerPanel.focus.test.ts、src/components/ComputerPanel.instabox.test.ts、src/components/ComputerPanel.lazy.test.ts、src/components/ComputerPanel.live.test.ts、src/components/ComputerPanel.simple.test.ts、src/components/ComputerPanel.tabs.test.ts、src/components/ComputerPanel.takeover.test.ts、src/components/ComputerPanel.tsx、src/components/FailedTurnRow.place.test.ts、src/components/InstaboxSnapshots.test.tsx、src/components/InstaboxSnapshots.tsx、src/components/LocalComputerSection.test.ts、src/components/LocalComputerSection.tsx、src/components/TeamMapPage.edges.test.ts、src/components/TeamMapPage.tsx、src/components/bot-panel/ComputerTab.tsx、src/components/bot-settings/AccessSection.test.ts、src/components/bot-settings/AccessSection.tsx、src/lib/local-computer.test.ts、src/lib/local-computer.ts、src/lib/notices.test.ts、src/lib/place-view.ts、src/lib/remote-desktop.test.ts、src/lib/remote-desktop.ts、src/locales/en.json、src/locales/no-retired-provider-visible.test.ts、src/locales/source-hashes.json、src/locales/vocabulary.test.ts、src/locales/zh.json、verification.txt。pnpm exec vitest run <文件>逐文件通过,共 46 个文件、56 次运行、934 个测试执行通过;快照路由、snapshot-conflicts、snapshot-wiring、wiring、core 五组 e2e 各连续 3 次通过。pnpm exec tsc -p tsconfig.server.json、pnpm exec tsc -b --pretty false、改动文件pnpm exec oxlint --deny-warnings、pnpm i18n:check、git diff --check均通过。zh/en 值无 Boat。仓库缺少验证 README,使用隔离假服务和临时数据 fixture;完整脱敏输出见verification.txt。未提交 git。T-1252 第 5 轮
server/index.ts、server/instabox/power.ts、server/instabox/power.test.ts、server/instabox/wiring.e2e.test.ts、server/local-vm-screens.e2e.test.ts、server/surface-pins.e2e.test.ts、本报告、verification.txt。修正 Auto 预览及切换后端休眠,补隔离回归;旧预览夹具显式选择原假服务后端。cloudKindOf判断,缺省后端建机后切到 VPS 也会休眠;共用 VM 和多屏选择规则保持原样。pnpm exec vitest run <文件>逐文件验证 32 个文件(含server/instabox/全部测试、云后端、预览、Local VM 和文件大小检查),54 次运行、924 次测试执行通过;9 组 e2e 均连续 3 次通过。VNC 浏览器和 VPS 图像子用例初次缺依赖跳过,已用临时 Chromium 启动器和 Pillow 环境补跑全部通过,无遗留跳过。pnpm exec tsc -p tsconfig.server.json、改动文件pnpm exec oxlint --deny-warnings、git diff --check通过。验证 README 缺失,使用现有隔离夹具;完整脱敏输出见verification.txt。未提交 git。T-1252 第 6 轮
server/index.ts、server/instabox/wiring.e2e.test.ts、shared/place-view.ts、shared/place-view.test.ts、src/components/CloudBackendPicker.tsx、src/components/CloudBackendPicker.test.ts、src/components/ComputerPanel.tsx、src/components/ComputerPanel.simple.test.ts、src/components/PlaceChip.tsx、src/components/PlaceChip.test.ts、src/components/WorksOnGrid.tsx、src/components/bot-panel/ComputerTab.tsx、src/components/bot-settings/AccessSection.tsx、src/components/bot-settings/AccessSection.test.ts、src/lib/place.ts、src/lib/place-view.ts、本报告、verification.txt。server/instabox/全部测试通过,wiring 和 VNC e2e 各连续 3 次通过(每次 8、32 项);pnpm exec tsc -b --pretty false、pnpm exec tsc -p tsconfig.server.json、pnpm exec oxlint --deny-warnings、pnpm i18n:check、git diff --check通过。未提交 git。第 7 轮
server/index.ts、server/instabox/wiring.ts、server/instabox/preview.e2e.test.ts、本报告、verification.txt。Auto 预览使用独立的 2.5 秒云端探测;补新建、未保存后端和显式选择 三种智能体的隔离回归,断言挂起请求取消且 4 秒内返回vm。pnpm exec vitest run <文件> --maxWorkers=1,23 个文件、41 次运行、696 次测试执行通过;包含server/instabox/全部测试、预览选择、多屏和文件大小检查,9 组 e2e 各连续 3 次通过,无跳过。pnpm exec tsc -p tsconfig.server.json、pnpm exec oxlint --deny-warnings server/index.ts server/instabox/wiring.ts server/instabox/preview.e2e.test.ts、git diff --check通过。验证 README 缺失,使用现有隔离夹具;完整脱敏输出见verification.txt。未提交 git。第 8 轮
src/components/RoutineCalendarPage.tsx、src/components/RoutineCalendarPage.dialogs.test.ts、本报告、verification.txt。全仓检索前端 lock 与后端判断,仅发现并修正RoutineCalendarPage.tsx:1463的同类误判;新增 12 项回归覆盖 lock 开关下的显式/缺省 、VPS、box、本机和旧云例行任务。runOn === "cloud"处理保持不变。pnpm exec vitest run <文件> --maxWorkers=1逐文件通过 9 个相关测试文件、107 项(含文件大小检查);新增测试修复前准确复现 2 项失败。pnpm exec tsc -b --pretty false、pnpm exec oxlint --deny-warnings src/components/RoutineCalendarPage.tsx src/components/RoutineCalendarPage.dialogs.test.ts、git diff --check均通过。本轮仅改前端显示,无涉及的端口 e2e;验证 README 缺失,使用隔离组件夹具。完整输出见verification.txt,未提交 git。验收证据
审核、安全审查和测试结论见本 PR 检查状态及评论。
风险与回退
待补充风险;合并后可通过 revert 压缩提交回退。
🤖 Generated with Claude Code