Repository navigation
fix(sonodaq): build and package macOS ARM64 SDK 1.4 runtime - #4
Merged
Merged
Conversation
xiaopingshao
marked this pull request as ready for review
November 16, 2026 07:42
xiaopingshao
added a commit
to crysound/OpenTest
that referenced
this pull request
Nov 16, 2026
…#29) Restore the macOS ARM64 runtime from the Windows-matched historical algorithm baseline `46a640bdc6d019ec4a51dbdef7f675d1c5700b06`: production FFTC libraries and the original default license at the backend platform root, without `prd` or a test-runtime payload. Frontend POSIX loading and packaging use the same FFTC layout. Existing Java entry points delegate to the neutral native exports; Windows payload files are unchanged. Review fixes in fd52282: - Reject macOS non-production staging and missing/empty root licenses, with regression tests. - Cover all 33 Java compatibility/native signature pairs. Generate JNI declarations with javac, including generic/multiline methods, overloads and escaped identifiers; verify actual exports and run the real JVM smoke via one documented entry point. - Preserve the seven legacy log-message strings while retaining SDK-compatible enum identifiers. - Record the complete algorithm patch at fixed private NativeDriver merge commit 92982a31, with SHA256 and replay instructions. Keep the detached/dirty source record truthful. - Limit SHA256SUMS to runtime binaries and License.dat; validate algorithm metadata separately. - Correct the FFT dependency failure test to select the configured platform library without changing Linux binaries or its FFT backend. Current local macOS validation: - Algorithm runtime: 227 tests passed, including 33 binding cases. - Frontend native addon: 45 passed. - Packaging/license: 35 passed, one case-sensitive-filesystem test skipped. - Verifier regressions: 2 passed. - Eight ARM64 dylibs load; all 323 javac-generated backend JNI exports match. Windows algorithm exports: 148/148 static PE matches, not Windows execution. - Real JVM -Xcheck:jni: original default license imports; FFT returns expected feature-denied 13300010; license state releases in finally. - Seven legacy log-message strings checked by a compiled C++ probe; framework boundary guard passed. No hardware or full licensed FFT acceptance claimed. Owner confirmations still requested in the two open review topics: 1. JNI/framework owner: Windows and macOS evidence is supplied. No Linux backend payload is present; shared POSIX NativeDriver sources use the same neutral names, but externally supplied Linux binary compatibility remains unverified. Confirm the acceptable scope; this PR does not implement Linux delivery. 2. Authorization/product-release owner: confirm the signed initial device001 machine-match exception and default community FFT feature-denial behavior. The full patch is traceable; no SKU restriction or additional entitlement bypass has been silently introduced. macOS and Windows default license JSON payload/signature are equal (trailing newline differs). Core minimum macOS is 12. SonoDAQ SDK 1.4.0 requires macOS 26 and is delivered separately by crysound/OpenTest-Plugins#4. Its prior 14/14 result and generated local package depended on shared runtime fixes now withdrawn; they are not current-branch acceptance/release artifacts. Unrelated shared CI/runtime fixes were withdrawn in f4cd7ac and #30 is closed. No workflow changes remain. Windows frontend/backend tests are informational under the currently active main rules; docs-policy, CodeQL rules, two designated-team approvals and resolved discussions remain required. No merge or approval bypass is requested. Refs #28 Companions: crysound/OpenTest-NativeDriver#1 (merged), crysound/OpenTest-Plugins#4. --------- Co-authored-by: xiaopingshao <25676237+xiaopingshao@users.noreply.github.com>
yangdekun2026
approved these changes
Nov 16, 2026
KyleHuangFromHZ
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the official SonoDAQ 1.4.0 macOS ARM64 headers/runtime, default macOS CMake SDK resolution, test runtime search paths, and reproducible
.otpluginpackaging. Vendor inputs remain original; staged copies strip local/debug symbols with exported-symbol equality checks and ad-hoc signing. SDK requires macOS 26; the vendor development-path exception remains as requested.Release compilation, staged SDK version query and runtime-module loading succeeded. The earlier 14/14 root CTest result and generated local package used OpenTest shared runtime fixes in 10dced55. Those fixes are now withdrawn from #29 as unrelated scope, so the earlier results/package are not acceptance/release artifacts for the current branch. Property payload length and channel streaming failures need separate owner triage. No hardware acceptance is claimed.
Refs crysound/OpenTest#28
Companion: crysound/OpenTest#29; crysound/OpenTest-NativeDriver#1 (merged).