Skip to content

fix(axis): cap high-precision waveform viewports - #5

Merged
cuimmm merged 1 commit into
mainfrom
feature/waveform-timestamp-window
Nov 16, 2026
Merged

cuimmm merged 1 commit into
mainfrom
feature/waveform-timestamp-window

Conversation

@KyleHuangFromHZ

Copy link
Copy Markdown
Collaborator

Summary

Apply the existing intervalMax restriction to high-precision linear X axes. An OpenTest waveform with a preview can now enforce its 15-second detail viewport with h:m:s selected. Bump the OpenTest package to 1.0.1-opentest.31.

Set a 15 s maximum → request a 120 s interval
Before: high-precision X axis keeps the full 120 s
After:  high-precision X axis shows 52.5–67.5 s (15 s)

Evidence

  • The regression reproduced the uncapped interval before the fix. It now passes for manual intervals, wheel zoom, fit, and removing the restriction.
  • CRYChart: 1,222 tests passed, 2 skipped; 31 OpenTest contract tests passed; typecheck and build passed.
  • OpenTest on windows-huang confirmed the 15-second cap with both s and h:m:s, including wheel zoom.

Merge Danger

Door: Two-way. Reverting restores the previous axis behavior; the patch changes no stored data.

Blast Radius: High-precision linear axes with an explicit maximum interval.

@cuimmm
cuimmm merged commit 1e0db3c into main Nov 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants