Repository navigation
ci: run unit tests with checkmate - #31
Merged
Merged
Conversation
Replaces the direct nim c -r test steps with checkmate, configured via the committed .checkmate.toml. Each memory manager (orc, arc, refc) runs the suite 10 times in-process with --bail for flake detection. Verified locally that checkmate propagates failures as a non-zero exit (unlike nimble test) and that --nimflags carries the mm selection. The .checkmate/ cache dir is gitignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the CI test job from direct
nim c -rinvocations to the checkmate test runner, configured by the committed.checkmate.toml. Each memory manager (orc, arc, refc) now runs:which executes the whole suite 10 times per memory manager (in-process looping, so it's fast: ~5s locally for 2440 test executions) and bails at the first failure. The looping gives us flake detection we didn't have, which matters for a library whose test surface includes ref-heavy validator trees under three memory managers.
Verified before switching
The reason the previous steps bypassed nimble was its swallowed exit codes, so the same property was checked for checkmate empirically:
--nimflags:--mm:arc/refccarry the memory-manager selection correctly (verified locally for all three)Also adds the
.checkmate/cache directory to.gitignore, per the config file's own guidance.