BST: Insert an equal value in right subtree - #4
Open
darionhaase wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings from Aachen,
we link to a web version of this tool for our students of the data structures and algorithms lecture so they can generate more exercises on their own.
Unfortunately, the algorithm for insertion into binary search trees differs from the one we present in the lecture. If the value to insert is the same as the one in the root, we insert it into the right subtree. The current implementation inserts into the left subtree.
While it does not matter for a BST, it can cause deviations in the required rotations for AVL trees. As I do not know what your implementation's literature reference is, maybe you want to adapt to our lecture's behaviour with this PR :)