update project struct#10
Conversation
# Conflicts: # gradle/libs.versions.toml
🔧 update .kts file
🔧 update .kts file
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the project structure by extracting common functionality into a base module and restructuring the codebase for better maintainability. The main changes include creating a new mordecaix-base module, updating the build configuration system, and restructuring source paths.
- Extracted common functionality into a new
mordecaix-basemodule containing utilities, time classes, and platform abstractions - Updated build logic to use a more structured approach with new plugin conventions and configuration extensions
- Restructured project hierarchy with better separation of concerns between modules
Reviewed Changes
Copilot reviewed 198 out of 521 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| mordecaix-base/ | New base module containing common utilities, time classes, platform abstractions, and storage implementations |
| mordecaix-build-logic/ | Updated build configuration with new plugin structure and configuration extensions |
| mordecaix-app/ | Restructured main application module with updated dependencies and imports |
| mordecaix-zipline/ | New zipline module with multiplatform configuration |
| mordecaix-test/ | Test modules for Android configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| implementation(libs.jetbrains.browser) | ||
| } | ||
|
|
||
| nonWebCommonMain. dependencies { |
There was a problem hiding this comment.
There's an extra space before 'dependencies' that should be removed.
| nonWebCommonMain. dependencies { | |
| nonWebCommonMain.dependencies { |
| @@ -1,3 +1,5 @@ | |||
| import org.jetbrains.kotlin.org.jdom.Namespace.getNamespace | |||
There was a problem hiding this comment.
This import appears to be incorrect and unused. The import should likely be removed as it doesn't correspond to any usage in the file.
| import org.jetbrains.kotlin.org.jdom.Namespace.getNamespace |
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.android | ||
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.debugImplementation | ||
| import kotlin.jvm.java |
There was a problem hiding this comment.
The imports contain generated accessor paths that are unstable and will break builds. These should be replaced with proper imports or removed if unused.
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.android | |
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.debugImplementation | |
| import kotlin.jvm.java |
| @@ -0,0 +1,34 @@ | |||
| plugins { | |||
| id("com.android.application") | |||
There was a problem hiding this comment.
This plugin configuration expects to be applied to an Android application but the function plugin should not include application-specific plugins. Consider moving these to the base application plugin.
| id("com.android.application") |
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.debugImplementation | ||
| import libsEx | ||
|
|
There was a problem hiding this comment.
The import uses a generated accessor path that is unstable and will cause build failures. Use proper dependency configuration syntax instead.
| import gradle.kotlin.dsl.accessors._c8e23648a0123cabac06a951e2864907.debugImplementation | |
| import libsEx | |
| import libsEx |
🎨 edit file struct, project struct
🔧 update .kts file