Conversation
|
Hello @buixor and thank you for your contribution! I'm a bot that helps maintainers to validate scenarios and ensure they include all the required information. The following items have errors: crowdsecurity/crs-exclusion-plugin-cpanel:
crowdsecurity/crs-exclusion-plugin-dokuwiki:
crowdsecurity/crs-exclusion-plugin-drupal:
crowdsecurity/crs-exclusion-plugin-nextcloud:
crowdsecurity/crs-exclusion-plugin-phpbb:
crowdsecurity/crs-exclusion-plugin-phpmyadmin:
crowdsecurity/crs-exclusion-plugin-wordpress:
crowdsecurity/crs-exclusion-plugin-xenforo:
Mitre ATT&CKInformation about mitre attack can be found here.
Expected format is (where labels:
classification:
- attack.TXXXXCVEsIf your scenario covers a specific CVE (Common Vulnerabilities and Exposures), please add it. Expected format is (where labels:
classification:
- cve.CVE-XXX-XXXBehaviorsPlease identify the behavior(s) your scenario is targeting. You can find the list of available behaviors here. Expected format is (where labels:
behavior: <behavior>See the labels documentation for more information. |
There was a problem hiding this comment.
Pull request overview
Adds a new CrowdSec HTTP scenario that tags requests matching known technology/vendor probing paths (via an external lookup file), and wires it into the base HTTP collection with an accompanying test fixture.
Changes:
- Add
crowdsecurity/http-technology-probingtrigger scenario that looks uphttp_pathintechnology_probing.jsonand setstarget_techno. - Include the new scenario in
crowdsecurity/base-http-scenarios. - Add a dedicated
.tests/http-technology-probingdataset and assertions.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/crowdsecurity/http-technology-probing.yaml | New trigger scenario performing map-based path lookup and setting target_techno. |
| scenarios/crowdsecurity/http-technology-probing.md | Short scenario documentation. |
| collections/crowdsecurity/base-http-scenarios.yaml | Registers the new scenario in the base HTTP collection. |
| .tests/http-technology-probing/config.yaml | Test harness configuration for the new scenario. |
| .tests/http-technology-probing/http-technology-probing.log | Sample nginx access log inputs (positive and negative cases). |
| .tests/http-technology-probing/scenario.assert | Assertions validating overflows and target_techno metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| description: "Detect generic HTTP probing" | ||
| filter: | | ||
| if (evt.Meta.service == 'http' and | ||
| evt.Meta.log_type in ['http_access-log', 'http_error-log'] and |
There was a problem hiding this comment.
The scenario description says "Detect generic HTTP probing", but this scenario is specifically about technology/vendor fingerprinting (and sets target_techno). Consider updating the description to match the actual behavior so alerts/overflows are self-explanatory. Also, lines in the filter condition currently contain trailing whitespace; trimming it will avoid noisy diffs and formatting issues.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Done in 3d1d8ff: I updated the scenario description to match technology/vendor probing and removed the trailing whitespace in the filter lines.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hello @buixor and thank you for your contribution! I'm a bot that helps maintainers to validate scenarios and ensure they include all the required information. The following items have errors: crowdsecurity/crs-exclusion-plugin-cpanel:
crowdsecurity/crs-exclusion-plugin-dokuwiki:
crowdsecurity/crs-exclusion-plugin-drupal:
crowdsecurity/crs-exclusion-plugin-nextcloud:
crowdsecurity/crs-exclusion-plugin-phpbb:
crowdsecurity/crs-exclusion-plugin-phpmyadmin:
crowdsecurity/crs-exclusion-plugin-wordpress:
crowdsecurity/crs-exclusion-plugin-xenforo:
Mitre ATT&CKInformation about mitre attack can be found here.
Expected format is (where labels:
classification:
- attack.TXXXXCVEsIf your scenario covers a specific CVE (Common Vulnerabilities and Exposures), please add it. Expected format is (where labels:
classification:
- cve.CVE-XXX-XXXBehaviorsPlease identify the behavior(s) your scenario is targeting. You can find the list of available behaviors here. Expected format is (where labels:
behavior: <behavior>See the labels documentation for more information. |
Agent-Logs-Url: https://github.com/crowdsecurity/hub/sessions/ac391c70-f3f2-41da-a496-78626375dc17 Co-authored-by: buixor <990714+buixor@users.noreply.github.com>
Add a scenario that can detect probing towards specific technologies or vendors, thanks to:
For now, this scenario doesn't lead to a decision. If we're happy with the results at scale, we'll add a scenario that reprocesses overflows from this one and bans IPs that trigger X distinct technologies' probing.