Skip to content

Add feature to map.html#68

Open
rbeerster wants to merge 2 commits intocrotwell:devfrom
rbeerster:dev
Open

Add feature to map.html#68
rbeerster wants to merge 2 commits intocrotwell:devfrom
rbeerster:dev

Conversation

@rbeerster
Copy link
Contributor

Now you can click on a quake in the map and it will highlight the quake in the table and vice versa.

Now you can click on a quake in the map and it will highlight the quake in the table and vice versa.
@crotwell
Copy link
Owner

Thanks for making a pull request, I appreciate the effort.

I would prefer that style not be set on elements, and instead the style be create in the CSS for the page, and whether or not the style is applied to a row be controlled by whether it has the class set on it. So instead of setting style to be green on the row, you add the class SELECTED to the classList for that row. I believe this is a better way of doing CSS styling.

Also helpful if the PR doesn't include console.log and doesn't comment out code lines.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments