Open
Conversation
Now you can click on a quake in the map and it will highlight the quake in the table and vice versa.
Add feature to map.html
Owner
|
Thanks for making a pull request, I appreciate the effort. I would prefer that style not be set on elements, and instead the style be create in the CSS for the page, and whether or not the style is applied to a row be controlled by whether it has the class set on it. So instead of setting style to be green on the row, you add the class SELECTED to the classList for that row. I believe this is a better way of doing CSS styling. Also helpful if the PR doesn't include console.log and doesn't comment out code lines. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can click on a quake in the map and it will highlight the quake in the table and vice versa.