Skip to content

fix #930 add context menu option under Lookup selection -> Translate selection. #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlkleinpaste merged 1 commit into from
Jul 29, 2026
Merged

fix #930 add context menu option under Lookup selection -> Translate selection. #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 56 additions & 18 deletions src/gtk/menu_popup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,41 +1281,79 @@ G_MODULE_EXPORT void on_use_current_dictionary_activate(GtkMenuItem *

/******************************************************************************
* Name
* on_lookup_google_activate
* on_lookup_biblemap_activate
*
* Synopsis
* #include "gui/menu_popup.h"
*
* Description
* offer mouse-swept selection as a google maps browser reference.
* offer mouse-swept selection as a biblemap browser reference.
*
* Return value
* void
*/

G_MODULE_EXPORT void on_lookup_google_activate(GtkMenuItem *menuitem,
gpointer user_data)
G_MODULE_EXPORT void on_lookup_biblemap_activate(GtkMenuItem *menuitem,
gpointer user_data)
{
gchar *dict_key;
GtkWidget *html_widget = _get_html();
GdkDisplay *display = gtk_widget_get_display(html_widget);

XIPHOS_HTML_COPY_SELECTION(_get_html());
gtk_editable_select_region((GtkEditable *)widgets.entry_dict, 0,
-1);
gtk_editable_paste_clipboard((GtkEditable *)widgets.entry_dict);
dict_key =
g_strdup(gtk_editable_get_chars((GtkEditable *)widgets.entry_dict, 0, -1));
GtkClipboard *clipboard =
gtk_clipboard_get_for_display(display, GDK_SELECTION_PRIMARY);

if ((dict_key == NULL) || (*dict_key == '\0')) {
gchar *text = gtk_clipboard_wait_for_text(clipboard);
int len = (text ? strlen(text) : 0);

if (text && len && *text) {
gchar *enc_key = g_uri_escape_string(text, NULL, FALSE);
gchar *showstr = g_strconcat("http://www.biblemap.org/#", enc_key, NULL);
xiphos_open_default(showstr);
g_free(enc_key);
g_free(showstr);
} else
gui_generic_warning("No selection made");
} else {
gchar *enc_key = g_uri_escape_string(dict_key, NULL, FALSE);
gchar *showstr =
g_strconcat("http://www.biblemap.org/#", enc_key, NULL);
}

/******************************************************************************
* Name
* on_translate_activate
*
* Synopsis
* #include "gui/menu_popup.h"
*
* Description
* offer mouse-swept selection as a google translation request.
*
* Return value
* void
*/

G_MODULE_EXPORT void on_translate_activate(GtkMenuItem *menuitem,
gpointer user_data)
{
GtkWidget *html_widget = _get_html();
GdkDisplay *display = gtk_widget_get_display(html_widget);

GtkClipboard *clipboard =
gtk_clipboard_get_for_display(display, GDK_SELECTION_PRIMARY);

gchar *text = gtk_clipboard_wait_for_text(clipboard);
int len = (text ? strlen(text) : 0);

if (text && len && *text) {
gchar *enc_key = g_uri_escape_string(text, NULL, FALSE);
gchar *showstr = g_strconcat("https://translate.google.com/?sl=auto&tl=",
(sword_locale ? sword_locale : ""),
"&op=translate",
"&text=",
enc_key,
NULL);
xiphos_open_default(showstr);
g_free(enc_key);
g_free(showstr);
}
g_free(dict_key);
} else
gui_generic_warning("No selection made");
}

/******************************************************************************
Expand Down
6 changes: 4 additions & 2 deletions src/gui/menu_popup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,10 @@ void on_display_chapter_heading_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_use_current_dictionary_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_lookup_google_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_lookup_biblemap_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_translate_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_rename_perscomm_activate(GtkMenuItem *menuitem,
gpointer user_data);
void on_dump_perscomm_activate(GtkMenuItem *menuitem,
Expand Down
18 changes: 14 additions & 4 deletions ui/xi-menus-popup.gtkbuilder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,19 +801,29 @@
<property name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="label" translatable="yes">Use Current Dictionary</property>
<property name="label" translatable="yes">_Use Current Dictionary</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_use_current_dictionary_activate" swapped="no"/>
</object>
</child>
<child>
<object class="GtkMenuItem" id="lookup_google">
<object class="GtkMenuItem" id="translate">
<property name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="label" translatable="yes">Browse in BibleMap.org</property>
<property name="label" translatable="yes">_Translate selection</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_lookup_google_activate" swapped="no"/>
<signal name="activate" handler="on_translate_activate" swapped="no"/>
</object>
</child>
<child>
<object class="GtkMenuItem" id="lookup_biblemap">
<property name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="label" translatable="yes">_Browse in BibleMap.org</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_lookup_biblemap_activate" swapped="no"/>
</object>
</child>
<child>
Expand Down
17 changes: 13 additions & 4 deletions ui/xi-menus.glade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,18 +1255,27 @@
<child>
<widget class="GtkMenuItem" id="use_current_dictionary">
<property name="visible">True</property>
<property name="label" translatable="yes">Use Current Dictionary</property>
<property name="label" translatable="yes">_Use Current Dictionary</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_use_current_dictionary_activate" last_modification_time="Sat, 28 Feb 2009 04:28:54 GMT"/>
</widget>
</child>

<child>
<widget class="GtkMenuItem" id="lookup_google">
<widget class="GtkMenuItem" id="translate">
<property name="visible">True</property>
<property name="label" translatable="yes">Browse in BibleMap.org</property>
<property name="label" translatable="yes">_Translate selection</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_lookup_google_activate" last_modification_time="Tue, 23 Jun 2009 11:14:54 GMT"/>
<signal name="activate" handler="on_translate_activate" last_modification_time="Tue, 23 Jun 2009 11:14:54 GMT"/>
</widget>
</child>

<child>
<widget class="GtkMenuItem" id="lookup_biblemap">
<property name="visible">True</property>
<property name="label" translatable="yes">_Browse in BibleMap.org</property>
<property name="use_underline">True</property>
<signal name="activate" handler="on_lookup_biblemap_activate" last_modification_time="Tue, 23 Jun 2009 11:14:54 GMT"/>
</widget>
</child>

Expand Down