Skip to content

replace old hash-based anchor setting with modern scrollIntoView(). #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlkleinpaste wants to merge 2 commits into from
Closed

replace old hash-based anchor setting with modern scrollIntoView(). #1352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f1016
replace old hash-based anchor setting with modern scrollIntoView().
karlkleinpaste Jul 28, 2026
7132242
differentiate old-but-working location.hash for modern webkit2 vs mac…
karlkleinpaste Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions src/gtk/utilities.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,11 +1320,34 @@ HtmlOutput(char *text, GtkWidget *gtkText, MOD_FONT *mf, char *anchor)
for (q = safe_anchor; (q = strstr(q, "</")) != NULL; q += 2)
q[1] = '\\';
g_free(esc_anchor);
buf =
g_strdup_printf("<script type=\"text/javascript\" language=\"javascript\">"
" window.onload = function () { window.location.hash = \"%s\"; }"
" </script>",
safe_anchor);
#ifdef WIN32
// old windows webkit1 requires different attempt at scroll-to-anchor.
buf = g_strdup_printf("<script type=\"text/javascript\">"
"window.onload = function() {"
" setTimeout(function() {"
" var name = '%s';"
" var el = document.getElementsByName(name)[0] || document.getElementById(name);"
" if (el) {"
" var y = 0;"
" var node = el;"
" while (node) {"
" y += node.offsetTop;"
" node = node.offsetParent;"
" }"
" window.scrollTo(0, y);"
" document.documentElement.scrollTop = y;"
" document.body.scrollTop = y;"
" }"
" }, 10);"
"};"
"</script>", safe_anchor);
#else
// the older location.hash method still works most reliably in modern webkit2.
buf = g_strdup_printf("<script type=\"text/javascript\" language=\"javascript\">"
" window.onload = function () { window.location.hash = \"%s\"; }"
" </script>",
safe_anchor);
#endif
g_free(safe_anchor);
XIPHOS_HTML_WRITE(html, buf, strlen(buf));
g_free(buf);
Expand Down