-
Notifications
You must be signed in to change notification settings - Fork 149
Update concepts links in CRDs #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Rae Sharp <resharp20@gmail.com>
b0fe6f8 to
23c5209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this and taking the initiative to get it updated @tr0njavolta!
So typically when we do a docs release, I just copy the entirety of the https://github.com/crossplane/crossplane/tree/main/cluster/crds folder over here to the docs repo. If we don't also follow up the issue you opened, then we may accidentally overwrite these updates during the release.
Do you want to take a crack at crossplane/crossplane#7043, or would you prefer someone else takes that? I'll be happy to support your effort if you want to give it a go.
It would basically involve updating the source code comments, e.g. https://github.com/crossplane/crossplane/blob/main/apis/apiextensions/v2/xrd_types.go#L246 and then running earthly +generate to make sure the CRDs get updated from those source changes.
Interested in doing that? 😇
|
@jbw976 @tr0njavolta added the PR in crossplane: crossplane/crossplane#7045 |
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tr0njavolta take a look at the feedback on crossplane/crossplane#7045 (review), that would probably apply here in this PR too

This PR updates the links in the CRDs to account for new navigation paths:
https://docs.crossplane.io/latest/concepts/environment-configs > https://docs.crossplane.io/latest/composition/environment-configs/
https://docs.crossplane.io/latest/concepts/compositions > https://docs.crossplane.io/latest/composition/compositions/
https://docs.crossplane.io/latest/concepts/composite-resource-definitions > https://docs.crossplane.io/latest/composition/composite-resource-definitions/
https://docs.crossplane.io/latest/concepts/composition-functions > https://docs.crossplane.io/latest/packages/functions/
https://docs.crossplane.io/latest/concepts/providers/#runtime-configuration > https://docs.crossplane.io/latest/packages/providers/#runtime-configuration
https://docs.crossplane.io/latest/concepts/packages > https://docs.crossplane.io/latest/packages/
https://docs.crossplane.io/latest/concepts/usages > https://docs.crossplane.io/latest/managed-resources/usages/
https://docs.crossplane.io/latest/concepts/providers > https://docs.crossplane.io/latest/packages/providers/