feat(ui): support deep links for composite kind details#224
Open
danieldides wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
feat(ui): support deep links for composite kind details#224danieldides wants to merge 1 commit intocrossplane-contrib:mainfrom
danieldides wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Daniel Dides <ddides@bridgephase.com>
Collaborator
|
Hi @danieldides . Thanks for the contribution. that is a great feature. I have went through the code. All looks fine to me. just please change the target branch to pre-release instead of main so that we can have a release candidate and then once we do the merge with main we have the release containing all other changes as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to deeplink to any Crossplane composite resource by name on the composite-resources tab. We're deploying Crossview alongside a proprietary application that allows users to create resources and want to be able to provide links from our application to Crossview that allows users to jump straight to their provisioned resources to view more information on them. I tried to make the change as minimal and non-invasive as possible, not creating any new views.
Examples
Setup
Create a fresh kind cluster:
Next Steps (Demo Flow)
Install the function required by
k8s/crossplane-example/compositions.yaml:Create a few more claims in the existing file and then apply the existing demo manifests from this repo:
http://localhost:5173/composite-resources/XNginx?name=<selected-resource-name>Verify deep-link and reload behavior:
Verify close behavior: