Skip to content

fix(postman): preserve API Key placement during import - #206

Merged
crizant merged 2 commits into
mainfrom
feature/desktop-auth-fields
Nov 3, 2026
Merged

crizant merged 2 commits into
mainfrom
feature/desktop-auth-fields

Conversation

@crizant

@crizant crizant commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Postman Collection v2 and v2.1 API Key exports use in, while Probe executors require placement. Normalize header and query during import so imported credentials execute in the selected location.

Preserve variable references and unrelated properties. Missing or invalid placement produces a diagnostic without a default; conflicting in and placement values are both retained with a warning. Remove the incorrect API Key execution_unsupported warning.

Validation:

  • Postman importer suite, including both formats, placement edge cases, property preservation, and OpenCollection save/reload.
  • Imported API Key execution against a local HTTP server for both header and query placement.
  • Related HTTP API Key, WebSocket authentication, and application import tests.
  • Formatting and Clippy for probe-postman and probe-application passed.

Full workspace checks remain for CI.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between df7e88c and 6d22e1f.

Files selected for processing: 7
  • CHANGELOG.md
  • crates/application/tests/execution.rs
  • crates/desktop/src/app/tests/editor_state.rs
  • crates/postman/src/conversion/authentication.rs
  • crates/postman/src/tests.rs
  • tests/fixtures/postman/collection-apikey-v2.1.json
  • tests/fixtures/postman/collection-apikey-v2.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

- Import header and query placements correctly, and report missing, invalid, or conflicting settings
- Add coverage for Postman collection v2 and v2.1
@crizant
crizant force-pushed the feature/desktop-auth-fields branch from 133d831 to 42973bf Compare November 3, 2026 08:01
@crizant crizant changed the title feat(desktop): add dedicated authentication fields fix(postman): preserve API Key placement during import Nov 3, 2026
@crizant
crizant merged commit ac3e3b2 into main Nov 3, 2026
9 checks passed
@crizant
crizant deleted the feature/desktop-auth-fields branch November 3, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant