Repository navigation
fix(desktop): prevent hover styling on disabled manager actions - #203
Merged
Merged
Conversation
- Add disabled-aware icon and remove-row button helpers - Apply them to environment and certificate manager actions
Contributor
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Disabled-aware button helpers crates/desktop/src/components/controls/buttons.rs, crates/desktop/src/components/controls.rs, crates/desktop/src/components/mod.rs |
New helpers accept a disabled flag. Disabled icon buttons use a default cursor; enabled buttons retain pointer and hover styling. The control modules re-export the new helpers. |
Certificate and environment controls crates/desktop/src/app/chrome/certificates.rs, crates/desktop/src/app/chrome/environments.rs |
These controls pass their existing busy, list-position, and add-disabled conditions to the disabled-aware helpers. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
Minimal · up to 242d5
-
No actionable merge-blocking risk is established by the reviewed changes.
Pre-merge checks: 
4
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by CodeRabbit