Skip to content

fix(desktop): prevent hover styling on disabled manager actions - #203

Merged
crizant merged 1 commit into
mainfrom
feature/fix/disabled-manager-actions
Oct 29, 2026
Merged

crizant merged 1 commit into
mainfrom
feature/fix/disabled-manager-actions

Conversation

@crizant

@crizant crizant commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Apply disabled-state styling before hover styling so disabled manager actions do not show hover effects.
  • Use the shared disabled-aware button helpers for environment and certificate manager actions.

Testing

  • Not run (not specified).

Summary by CodeRabbit

  • Bug Fixes
    • Certificate list controls are disabled while the list is busy, and moving a certificate is unavailable at the top or bottom of the list.
    • Environment controls are disabled while busy or when adding an environment is unavailable.
    • Disabled controls now show a non-interactive cursor, while enabled icon controls retain pointer and hover styling.

- Add disabled-aware icon and remove-row button helpers
- Apply them to environment and certificate manager actions
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a5c8a30 and 242d5e2.

Files selected for processing: 5
  • crates/desktop/src/app/chrome/certificates.rs
  • crates/desktop/src/app/chrome/environments.rs
  • crates/desktop/src/components/controls.rs
  • crates/desktop/src/components/controls/buttons.rs
  • crates/desktop/src/components/mod.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Button helpers now accept disabled state. Certificate and environment controls use these helpers with their existing disabled conditions.

Changes: Disabled-aware controls

Layer / File(s) Summary
Disabled-aware button helpers
crates/desktop/src/components/controls/buttons.rs, crates/desktop/src/components/controls.rs, crates/desktop/src/components/mod.rs
New helpers accept a disabled flag. Disabled icon buttons use a default cursor; enabled buttons retain pointer and hover styling. The control modules re-export the new helpers.
Certificate and environment controls
crates/desktop/src/app/chrome/certificates.rs, crates/desktop/src/app/chrome/environments.rs
These controls pass their existing busy, list-position, and add-disabled conditions to the disabled-aware helpers.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 242d5

No actionable merge-blocking risk is established by the reviewed changes.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preventing hover styling on disabled desktop manager actions.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@crizant
crizant merged commit 04d2199 into main Oct 29, 2026
9 checks passed
@crizant
crizant deleted the feature/fix/disabled-manager-actions branch October 29, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant