Added softReset and functions to test and set network time#29
Open
rharrison wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @rharrison, first of all thanks for your contribution, but why do you change the pins for Rx & Tx? |
Author
Owner
|
Please change the pinout. Probably is better add parameters to the instanciation. Your changes are welcome, do a pull request will your changes :) |
| #include <SoftwareSerial.h> | ||
|
|
||
| SoftwareSerial SIM(RX_PIN,TX_PIN); | ||
| SoftwareSerial SIM(RX_PIN, TX_PIN); |
Owner
There was a problem hiding this comment.
It could be great if the values to instantiate SoftwareSerial are provided via arguments of the Sim800l class.. could you change that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I ran pretty on the code and set TX & RX to pins 3 & 2 respectively.