Repository navigation
fix: don't panic when no template is defined - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new %w logging calls produce malformed diagnostics, and the sample interval conflicts with the README.
3 open findings
What changed in this PR
Prevents panics when templates or scheduled tasks are undefined.
Changes:
- Safely handles empty or missing templates.
- Skips schedules referencing missing tasks.
- Improves task failure logging and disables optional sample tasks by default.
| File | Description |
|---|---|
main.go |
Adds startup-task error context. |
lib/task.go |
Validates templates before execution. |
lib/global.go |
Handles empty templates and invalid schedules. |
config.yaml |
Comments out optional Zabbix configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.