fix: slim discovery pr1 - #117
Merged
Merged
Conversation
added 2 commits
August 31, 2026 16:53
Discovery is an orchestrator only: wallet scans run in cafe-scanner-wallet. Extract address validation to internal/address, drop walletscan/evm/moralis from the server binary, and remove dead ScanWallet persistence helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery is HTTP orchestration only: validate address, publish to NATS, read results from persistence. Wallet scanning (RPC + indexer) stays in
cafe-scanner-wallet.Removes dead runtime code from the server binary (~1.5k lines):
internal/walletscan/,pkg/evm/,pkg/moralis/, andScanWallet. Address validation moves tointernal/address/.Coordinate with:
cafe-deployandcafe-expressoPRs onfeat/slim-discovery-pr1(dropMORALIS_*from discovery-backend).What stays the same
GET /discovery/v1/rpcsstill readsblockchains[].rpcfrom YAML (metadata only)Ops note
MORALIS_API_KEYis no longer required on discovery-backend; still required on cafe-scanner-wallet.