[chewi]

This was added with practically no context. Gentoo itself has already patched out these lines for a long time.

Thank you for stepping up as the new upstream. 🙂

[crazy-max]

windows ci seems to fail: https://github.com/crazy-max/innoextract/actions/runs/36776795485/job/117435204158?pr=18#step:5:17

FAILED: [code=1] CMakeFiles/innoextract.dir/src/cli/main.cpp.obj 
D:\a\_temp\msys64\mingw64\bin\c++.exe -DBOOST_CONTAINER_NO_LIB -DBOOST_CONTAINER_STATIC_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_DATE_TIME_STATIC_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_FILESYSTEM_STATIC_LINK=1 -DBOOST_IOSTREAMS_NO_LIB -DBOOST_IOSTREAMS_STATIC_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_PROGRAM_OPTIONS_STATIC_LINK -DBOOST_RANDOM_NO_LIB -DBOOST_RANDOM_STATIC_LINK -DBOOST_SYSTEM_DISABLE_THREADS -DBOOST_SYSTEM_USE_UTF8 -DLZMA_API_STATIC -DNOMINMAX -DUNICODE -DWIN32_LEAN_AND_MEAN -D_UNICODE -D_WIN32_WINNT=0x0502 -ID:/a/innoextract/innoextract/src -ID:/a/innoextract/innoextract/build -Wall -Wextra -Warray-bounds=2  -Wcast-qual -Wcatch-value=3 -Wconversion  -Wdouble-promotion -Wduplicated-cond -Wextra-semi -Wformat=2 -Wheader-guard  -Winit-self -Wkeyword-macro  -Wlogical-op -Wmissing-declarations -Wnoexcept -Woverflow -Woverloaded-virtual -Wpessimizing-move -Wpointer-arith -Wredundant-decls  -Wshift-overflow -Wsign-conversion -Wstrict-null-sentinel -Wstringop-overflow=4 -Wundef -Wunused-const-variable=1 -Wunused-macros -Wvla -Wold-style-cast -Wshadow -Wno-maybe-uninitialized -Werror -ffast-math -std=c++17 -pedantic -fvisibility=hidden -fvisibility-inlines-hidden -O3 -DNDEBUG -std=c++17 -MD -MT CMakeFiles/innoextract.dir/src/cli/main.cpp.obj -MF CMakeFiles\innoextract.dir\src\cli\main.cpp.obj.d -o CMakeFiles/innoextract.dir/src/cli/main.cpp.obj -c D:/a/innoextract/innoextract/src/cli/main.cpp
In file included from D:/a/innoextract/innoextract/src/cli/main.cpp:44:
D:/a/innoextract/innoextract/src/util/windows.hpp:56:13: error: 'int util::isatty(int)' conflicts with a previous declaration
   56 | using util::isatty;
      |             ^~~~~~
In file included from D:/a/_temp/msys64/mingw64/include/sys/stat.h:14,
                 from D:/a/_temp/msys64/mingw64/include/wchar.h:19,
                 from D:/a/_temp/msys64/mingw64/include/c++/16.2.0/cwchar:49,
                 from D:/a/_temp/msys64/mingw64/include/c++/16.2.0/bits/postypes.h:42,
                 from D:/a/_temp/msys64/mingw64/include/c++/16.2.0/iosfwd:44,
                 from D:/a/_temp/msys64/mingw64/include/c++/16.2.0/iomanip:46,
                 from D:/a/innoextract/innoextract/src/cli/main.cpp:23:
D:/a/_temp/msys64/mingw64/include/io.h:191:15: note: previous declaration 'int isatty(int)'
  191 |   int __cdecl isatty(int _FileHandle) __MINGW_ATTRIB_DEPRECATED_MSVC2005;
      |               ^~~~~~

[chewi]

Okay, but that has absolutely nothing to do with this change.

[chewi]

I see you've had the same failure in the dev branch.