Repository navigation
cmake: avoid MinGW static Boost LTO link failures - #12
Merged
Merged
Conversation
MinGW GCC can fail the final link for static Boost builds with LTO enabled when Boost exception thunks are emitted in discarded COMDAT/linkonce sections. Disable LTO only for the translation units that trigger the linker-plugin failure so the rest of the target can keep using LTO. Also fix the BOOST_SYSTEM_USE_UTF8 condition to test CMake's standard WIN32 variable instead of the lowercase win32 spelling. Cherry-picked from dscharrer#209. Upstream commits: 505f16e, 33e2c7d Signed-off-by: Patryk Miś <foss@patrykmis.com>
|
While testing the merged fix, I noticed that -DDEBUG=ON enables src/cli/debug.cpp, which triggers the same GCC/MinGW LTO linker issue. The same workaround (-fno-lto) for src/cli/debug.cpp fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinGW GCC can fail the final link for static Boost builds with LTO enabled when Boost exception thunks are emitted in discarded COMDAT/linkonce sections. Disable LTO only for the translation units that trigger the linker-plugin failure so the rest of the target can keep using LTO.
Also fix the BOOST_SYSTEM_USE_UTF8 condition to test CMake's standard WIN32 variable instead of the lowercase win32 spelling.
Cherry-picked from dscharrer#209 (cc @PatrykMis)
Upstream commits: 505f16e, 33e2c7d