fix: Middleware Pipeline — Closure Captures Wrong Request#122
Open
fix: Middleware Pipeline — Closure Captures Wrong Request#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in the middleware pipeline where middleware modifications to the request object were not propagating to subsequent middleware in the chain.
Problem
In
HttpRequestHandler, the closure in the middleware loop was capturing$requestfrom the outer scope instead of using the$inputparameter:This caused all middleware to receive the original request, ignoring any modifications made by previous middleware.
Solution
Changed the closure to use the
$inputparameter:Testing
Added comprehensive tests in
MiddlewarePipelineTest.phpthat verify:Breaking Changes
None.
References