Add setHeader() method, keep withHeader() as alias#120
Merged
Conversation
s2x
commented
Apr 12, 2026
| return $this; | ||
| } | ||
|
|
||
| public function withHeader(string $name, string $value): self |
Collaborator
Author
There was a problem hiding this comment.
[Suggestion] The withHeader() method is described as a deprecated alias but lacks a @deprecated PHPDoc annotation. Without it, IDEs and static analysis tools won't warn users to migrate to setHeader().
Suggested change
| public function withHeader(string $name, string $value): self | |
| /** | |
| * @deprecated Use setHeader() instead. This method is kept for backward compatibility. | |
| */ | |
| public function withHeader(string $name, string $value): self |
— coder-model via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setHeader()method as the proper name for mutating operationwithHeader()as deprecated alias for backward compatibilityFixes #38