Add REQUEST_TIME and REQUEST_TIME_FLOAT to server bag#114
Merged
Conversation
Collaborator
Author
Code ReviewStrengths
Issues (all must be addressed before merge)Important
Minor
All issues above must be addressed before this PR can be merged. |
added 2 commits
April 5, 2026 22:26
- Enables Symfony profiler and debug toolbar to show request duration - Sets values using time() and microtime(true) at request conversion time - Adds unit test for the new values Closes #67
- Capture microtime(true) once and derive REQUEST_TIME from it - Tighten test assertions to 0.1s delta - Add assertion verifying REQUEST_TIME equals cast REQUEST_TIME_FLOAT
37f1c4c to
1b44dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REQUEST_TIME(unix timestamp) andREQUEST_TIME_FLOAT(unix timestamp with microseconds) to the server bag inRequestConvertertime()andmicrotime(true)at request conversion timeChanges
REQUEST_TIMEandREQUEST_TIME_FLOATto the server arraytestRequestTimeAndRequestTimeFloatAreSetto verify the values are correctly set[Unreleased]sectionCloses #67