Skip to content

Fixed the ingestion type parameter for DynamoDB data jobs #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanpardo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the ingestion type parameter for DynamoDB data jobs #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions croud/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,16 +901,16 @@
Argument(
"--ingestion-type", type=str,
choices=[
"IMPORT_ONLY",
"IMPORT_AND_CDC",
"CDC_ONLY"
"import-only",
"import-and-cdc",
"cdc-only"
],
required=True,
help="Determines how to ingest the data. "
"IMPORT_ONLY will just ingest the data "
"and finish. CDC_ONLY will continuously "
"import-only will just ingest the data "
"and finish. cdc-only will continuously "
"read CDC (Change Data Capture) events. "
"IMPORT_AND_CDC will first import the "
"import-and-cdc will first import the "
"data and then start listening for CDC "
"events."
),
Expand Down
2 changes: 1 addition & 1 deletion croud/clusters/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def import_jobs_create_from_dynamodb(args: Namespace) -> None:
extra_body["dynamodb"]["endpoint"] = args.endpoint
if args.ingestion_type:
extra_body["ingestion_type"] = args.ingestion_type
if "CDC" in extra_body.get("ingestion_type", ""):
if "cdc" in extra_body.get("ingestion_type", ""):
if args.kinesis_stream_name:
extra_body["dynamodb"]["kinesis_stream_name"] = args.kinesis_stream_name
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/commands/test_clusters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,7 @@ def test_import_job_create_from_dynamodb(mock_request):
kinesis_stream_name = "my_kinesis_stream_name"
secret_id = gen_uuid()
endpoint = "https://my-dynamodb-compatible-endpoint"
ingestion_type = "IMPORT_AND_CDC"
ingestion_type = "import-and-cdc"
call_command(
"croud",
"clusters",
Expand Down
Loading