feat(cli): ignore .git directory by default#1300
Open
risu729 wants to merge 1 commit intocrate-ci:masterfrom
Open
feat(cli): ignore .git directory by default#1300risu729 wants to merge 1 commit intocrate-ci:masterfrom
.git directory by default#1300risu729 wants to merge 1 commit intocrate-ci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788.
Since the
ignorecrate doesn't support this directly, I added anoverridesoption to explicitly ignore the.gitdirectory.ref: BurntSushi/ripgrep#2964
If it's preferable to set a default
extend_excludeand merge it instead, I'm happy to refactor accordingly.Apologies for the lack of tests and documentation.
I couldn't include tests because the
.gitdirectory is ignored by Git itself.As for documentation, I wasn't sure where this should be documented. Could you advise me on the appropriate place to add it?