fix: the tag project veiw endpoint not returning deleted projects#634
Merged
rhodinemma merged 1 commit intostagingfrom Nov 4, 2025
Merged
fix: the tag project veiw endpoint not returning deleted projects#634rhodinemma merged 1 commit intostagingfrom
rhodinemma merged 1 commit intostagingfrom
Conversation
rhodinemma
approved these changes
Nov 4, 2025
Contributor
rhodinemma
left a comment
There was a problem hiding this comment.
working as expected. thank you for this @CHRISTOPHERKADOGO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a soft delete filter to the tag projects query to ensure deleted projects are excluded from results.
Change Made:
Project.deleted.is_(False)filter to the existing SQLAlchemy query inTagProjectsViewMotivation:
The system uses soft deletion for projects, but the tag projects endpoint was previously returning all projects regardless of their deletion status. This could lead to users seeing projects that should no longer be visible.
Type of change
Trello Ticket ID
[Add Trello card URL here if applicable]
Example: https://trello.com/c/abc123/fix-deleted-projects-showing-in-tag-listings
How Can This Be Tested?
Test Scenarios:
Specific Test Cases:
Active projects should appear:
deleted = Falseand associated with tagDeleted projects should NOT appear:
deleted = Trueand associated with tag