Skip to content

Add autoloader and start migrating functions.php to classes#557

Open
irongulp wants to merge 3 commits into
craigk5n:masterfrom
irongulp:master
Open

Add autoloader and start migrating functions.php to classes#557
irongulp wants to merge 3 commits into
craigk5n:masterfrom
irongulp:master

Conversation

@irongulp
Copy link
Copy Markdown

No description provided.

@scrobbleme
Copy link
Copy Markdown

The package should start with a prefix like Webcalendar, or k5n\Webcalendar to avoid possible future conflicts with too generic namespaces. App\Helper is quite simple and there is a chance that it already is used...

@irongulp
Copy link
Copy Markdown
Author

irongulp commented Jul 6, 2025

The package should start with a prefix like Webcalendar, or k5n\Webcalendar to avoid possible future conflicts with too generic namespaces. App\Helper is quite simple and there is a chance that it already is used...

This isn't a package. Setting a namespace for the main application is needed to migrate Webcalendar to an OO app. The namespace proposed isn't going to conflict with anything.

Comment thread includes/init.php
* @package WebCalendar
*/

require_once __DIR__ . '/../vendor/autoload.php';
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would be best in a separate PR. Additionally, I prefer to not use autoload to better support offline installations and to avoid adding the vendor directory to the git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants