fix: remove stale entries from default enabled_plugins - #312
Merged
Merged
Conversation
The default enabled_plugins list referenced aprsd.plugins.location. LocationPlugin and aprsd.plugins.weather.OWMWeatherPlugin, neither of which exists in the package (weather.py defines USWeatherPlugin and USMetarPlugin only). Every default-config startup logged an ImportError for both. Point the weather entry at the real USWeatherPlugin class and drop the location entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default
enabled_pluginslist inaprsd/conf/common.pyreferenced two classes that don't exist in the package:aprsd.plugins.location.LocationPlugin— noaprsd/plugins/location.pyexistsaprsd.plugins.weather.OWMWeatherPlugin—weather.pyonly definesUSWeatherPluginandUSMetarPluginEvery default-config startup logged an
ImportErrorfor both (non-fatal, but error noise on every install, and the default claimed those plugins were enabled).Fix
locationentryUSWeatherPluginclassVerification
tests/test_plugin.py+tests/cmds/test_sample_config.py: 13 passedOWMWeatherPlugin/LocationPluginerrors at startup; plugin loading registers the actual default plugins