build: modernize Makefile to uv - #309
Merged
Merged
Conversation
- Drop the remote-fetched Makefile.venv include (curl + sha256sum, which is not available on macOS by default) - dev/run/server/build targets now use uv (venv + pip install -e ".[dev"] + uv run), matching the uv-based CONTRIBUTING.md - docs/check/test delegate to the tox envs that CI uses (tox -edocs, tox -elint/-efmt, tox -p all) - check no longer references the deleted fmt-check/ep8 tox envs - Remove dead docker-dev target (docker/Dockerfile-dev does not exist) and the requirements-dev.in lines (file does not exist) - README + install.rst: 'make' -> 'make dev' and describe the uv virtualenv the target creates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile contradicted the uv-based CONTRIBUTING.md that the README and install docs point to:
sha256sum --check— sha256sum is not present on macOS by default, so the include fails there before any target runs).make checkrantox -efmt-checkandtox -epep8— neither env exists in tox.ini.docker-devreferenced docker/Dockerfile-dev (does not exist);update-requirementsreferenced requirements-dev.in (does not exist).Changes:
uv venv,uv pip install -e ".[dev]",uv run ...); no remote fetch, no sha256sum.make docs/check/testdelegate to the tox envs CI actually runs (tox -edocs,tox -elint+tox -efmt,tox -p all).make build/upload(used by the README Release section) kept, adapted to uv + twine.make devand to describe the uv-created.venv.Verified:
make helprenders all targets;make -n dev/docs/build/cleandry-runs correct command sequences.