test: call _attach_piggyback_ack on a real thread instance - #293
Merged
Merged
Conversation
The piggyback ack unit tests invoked the instance method with None as self (APRSDPluginProcessPacketThread._attach_piggyback_ack(None, ...)), which works only by luck because the method happens not to use self. Construct a real APRSDPluginProcessPacketThread (with the APRSDClient mocked as before) and call the method through it. Addresses MINOR finding in docs/code-review-2026-09-18.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The piggyback-ack unit tests (
tests/threads/test_rx_piggyback.py) invoked theinstance method with
Noneasself:This only works because
_attach_piggyback_ackhappens not to useself— afragile pattern flagged as a MINOR finding in
docs/code-review-2026-09-18.md.Change
Construct a real
APRSDPluginProcessPacketThreadinsetUp(theAPRSDClientis mocked exactly as before) and call the method through the instance:
Pure test change — no production code touched.
Tests
pytest tests/threads/test_rx_piggyback.py: 3 passed. Full suite: 749 passed.ruff check aprsd/ tests/: clean.